Caves are live now, mod issues?

[PeterA]

Hey everyone,

 

Now that the caves beta branch (minus gifts and clothing) has gone out live to everyone playing DST, you may get new reports of bugs with your mods. While we try to ensure that the mod api isn't changed and continues to function as you expect, anything that is relying on the internals of the game's lua could run into issues. With a change as this caves one, there will inevitably be some conflicts.

Please let us know what issues pop up and we can discuss what changes should be made to get your mod back up and running again!

Thanks and enjoy the spelunking!

[Maris]

Since last update of Mod Tools I can rewrite my mod on Steam with the same version.

Is it a feature or a bug of Mod Tools?

Edited November 20, 2015 by Maris

[PeterA]

@Maris,  definitely a bug, thanks for mentioning it. I probably introduced that bug when the version_compatible check was done.

[PeterA]

@Maris, I wasn't able to reproduce the bug. Can you let me know what options in the Edit Mod dialog you are selecting, and which mod it is that you're updating?

 

Thanks!

[Maris]

@PeterA,

Hm, it has gone. Probably it was a Steam malfunction or I changed conditions. Sorry.

But I remember I could do it.

[PeterA]

@Maris, no worries, thanks for reporting it.

The mod uploader gets the version of the mod from the workshop item tags (which is known to not be that robust), so if something fails in getting the tags, then would be able to do the version change verification. 

If you see anything else strange like that, please let me know!

[Kooky]

I'm having an issue with my Mod called The Chester Family under the modworldgen.lua file.

 

I have attatched a screenshot of what it says to me. I've disabled other mods and get this same issue. I also noticed in my log file with the other mods enabled, it looks like most of my mods (any with a custom character) seems to have barfed all over themselves.

 

My entire mod has been attached as well.

 

Please leave me little notes in the code as well, I am still learning. I'd like to make a special chester family member available to follow you inside or outside of the caves named Cavester, who glows in the dark.

log.txt

chester family.zip

[Metroite]

I get a bug (If iam not the Host (But works with hosted dedicated server)) where I have more health then the maximum health and also I have already unlocked blueprints even if the world is freshly generated.

Noticed: It is a REALLY strange bug, sometimes I get new blueprints unlocked...

[Mobbstar]

I get a bug (If iam not the Host (But works with hosted dedicated server)) where I have more health then the maximum health and also I have already unlocked blueprints even if the world is freshly generated.

Noticed: It is a REALLY strange bug, sometimes I get new blueprints unlocked...

 

What mods do you use? Have you tried disabling some mods?

[DejaVuZXY]

I would like to report a bigger problem we have found together with other modders.

Currently many of the mods, that worked fine before the update, are causing server crashes.

This is not happening because the mods might be conflicting with other mods, no it is a standalone problem with every mod that uses the "mysterious" function that causes this to happen.

 

Let's go:

Mod "Craft Loot Run" produces this kind of error http://pastebin.com/FzHXY7r3 as the mod implements a feature where items can drop when mining boulders, trees, buildings etc. I updated the mod, but left the faulty code commented in if any dev wants to take a look. The server crash happens when, for example a boulder is being mined and the code triggers by trying to drop custom loot, but can't because the item was mysteriously destroyed before it reached the "reality"

 

Mod "Birds and Berries and Trees and Flowers for friends" produces simillar issue. Error http://pastebin.com/hiHXf7VZ . The mod implements, among other things, custom trees and pineapple bushes and the crash occures when you try to dig up the pineapple bush for example.

 

There are other mods as well most likely, but i haven't had the time to grab error logs from these, but the crash works similarly.

 

Is a function changed radically in a code somewhere on Klei side or what exactly is going on because a lot of modders are puzzled over this issue.

Thanks in advance! (and thanks for the Caves, hopefully the bugs can be ironed out and people can actually play for a little while without being stuck forever on 1 gameday as of the crashes all the time)

[afetogbo]

Disregard Kooky's post I have found the problem.

I changed line 136 to

local tasklist = require("map/tasks").sampletasks

[Kzisor]

Disregard Kooky's post I have found the problem.

I changed line 136 to

local tasklist = require("map/tasks").sampletasks

 

While this might work, it actually shouldn't work at all because that file is not returning anything for you to have access to. It's creating a global variable at the end of the file called 'tasks'; for this to actually work means that something is bugged.

 

Apparently this changed on November 20th update.

 

 

I would like to report a bigger problem we have found together with other modders.

Currently many of the mods, that worked fine before the update, are causing server crashes.

This is not happening because the mods might be conflicting with other mods, no it is a standalone problem with every mod that uses the "mysterious" function that causes this to happen.

Let's go:

Mod "Craft Loot Run" produces this kind of error http://pastebin.com/FzHXY7r3 as the mod implements a feature where items can drop when mining boulders, trees, buildings etc. I updated the mod, but left the faulty code commented in if any dev wants to take a look. The server crash happens when, for example a boulder is being mined and the code triggers by trying to drop custom loot, but can't because the item was mysteriously destroyed before it reached the "reality"

Mod "Birds and Berries and Trees and Flowers for friends" produces simillar issue. Error http://pastebin.com/hiHXf7VZ . The mod implements, among other things, custom trees and pineapple bushes and the crash occures when you try to dig up the pineapple bush for example.

There are other mods as well most likely, but i haven't had the time to grab error logs from these, but the crash works similarly.

Is a function changed radically in a code somewhere on Klei side or what exactly is going on because a lot of modders are puzzled over this issue.

Thanks in advance! (and thanks for the Caves, hopefully the bugs can be ironed out and people can actually play for a little while without being stuck forever on 1 gameday as of the crashes all the time)

 

Culprit for this is inst:Remove() should be called after all loot has been spawned. Make sure you drop the loot then remove the instance for the item.

Edited November 24, 2015 by Kzisor

[PeterA]

@Metroite, thanks for posting the issue. Have you isolated the issue to a single mod? If you have tracked it down to which mod is causing the problem, then that will help us track down if it's an issue with the game, or an issue with the mod.

 

Thanks!

[PeterA]

Hey @DejaVuZXY, thanks for posting the issue!

We've looked into the issue, and this is currently being caused by an assert we added to track down when GetPosition is getting called on an entity that has already been destroyed. The assert will eventually go away, because of the performance cost, but it's an indication that something is going wrong in the mod code (and will eventually give you incorrect positions).

As @Kzisor, found out with his Digable Reeds mod, the likely issues are cases where you're calling inst:Remove before you're done actually using the instance. Which I believe was most likely a consequence of mod code that was copied from now-incorrect game code.

 

I looked though "Craft Loot Run", and on the surface it appears to be correct. Are you still seeing issues with this mod?

 

"Birds and Berries and Trees and Flowers for friends" still appears to have issues though. In appletree.lua, in dig_up_stump the code is calling Remove on the inst, before the loot is spawned.

local function dig_up_stump(inst, chopper)	inst:Remove()	inst.components.lootdropper:SpawnLootPrefab("log")end

@ProfFarnsworth, have you looked into updating your mods so that the calls to Remove happen after?


 

 

 

[UnderwearApp]

Hey @DejaVuZXY, thanks for posting the issue!

We've looked into the issue, and this is currently being caused by an assert we added to track down when GetPosition is getting called on an entity that has already been destroyed. The assert will eventually go away, because of the performance cost, but it's an indication that something is going wrong in the mod code (and will eventually give you incorrect positions).

As @Kzisor, found out with his Digable Reeds mod, the likely issues are cases where you're calling inst:Remove before you're done actually using the instance. Which I believe was most likely a consequence of mod code that was copied from now-incorrect game code.

 

I looked though "Craft Loot Run", and on the surface it appears to be correct. Are you still seeing issues with this mod?

 

"Birds and Berries and Trees and Flowers for friends" still appears to have issues though. In appletree.lua, in dig_up_stump the code is calling Remove on the inst, before the loot is spawned.

local function dig_up_stump(inst, chopper)	inst:Remove()	inst.components.lootdropper:SpawnLootPrefab("log")end

@ProfFarnsworth, have you looked into updating your mods so that the calls to Remove happen after?

 

 

Whoopsy!

 

No I still can't see my own server, but once I can, OH BOY! I'll look at changing these lines for all items.

 

Thanks for the heads up!

[DejaVuZXY]

Hey @DejaVuZXY, thanks for posting the issue!

We've looked into the issue, and this is currently being caused by an assert we added to track down when GetPosition is getting called on an entity that has already been destroyed. The assert will eventually go away, because of the performance cost, but it's an indication that something is going wrong in the mod code (and will eventually give you incorrect positions).

As @Kzisor, found out with his Digable Reeds mod, the likely issues are cases where you're calling inst:Remove before you're done actually using the instance. Which I believe was most likely a consequence of mod code that was copied from now-incorrect game code.

 

I looked though "Craft Loot Run", and on the surface it appears to be correct. Are you still seeing issues with this mod?

 

"Birds and Berries and Trees and Flowers for friends" still appears to have issues though. In appletree.lua, in dig_up_stump the code is calling Remove on the inst, before the loot is spawned.

local function dig_up_stump(inst, chopper)	inst:Remove()	inst.components.lootdropper:SpawnLootPrefab("log")end

@ProfFarnsworth, have you looked into updating your mods so that the calls to Remove happen after?

 

 

With help i got my mods code sorted out. I don't know which version of the code you saw before, the broken one or now the fixed one, anyway it's working.

 

(a bit off-topic but...)

While i got a shard of your attention here (perhaps people will see what i just did there) i would also like to know if you're adding more options to worldgenoverride to be able to make other prfeabs renewable as well? Currently a LOT of things like Ancient Guardian, different statues, clockwork monsters etc etc etc are not renewable and in Wilderness servers that becomes a huge issue.

I have been using "Fix Multiplayer" mod for the resource renewal code and i love the method used there, unfortunately that part of the mod is not working very well and/or occasionally causes crashes. My dream would be to see a proper way to be able to make EVERY single prefab renewable. (and i can't stress that enough... every single one, the ones not needed for renewal can be configured not to then)

That said, Wilderness servers start lagging eventually when certaint prefabs overrun the place, may they be monsters or items or whatever else. Which means there should be some method that would clean up items left on the ground after X (configurable value) amount of days, same goes for monsters, there should be an option to set a configurable limit to these.

 

ALSO, there is a bug with monkey, i don't have the error log anymore, but basically i think it happens when they start turning into shadowmonkeys.

 

Nevertheless, good job on the caves, absolutely love it.

[PeterA]

While this might work, it actually shouldn't work at all because that file is not returning anything for you to have access to. It's creating a global variable at the end of the file called 'tasks'; for this to actually work means that something is bugged.

That's actually changed, so the correct fix now is what @afetogbo posted.

[Ipsquiggle]

(a bit off-topic but...)

While i got a shard of your attention here (perhaps people will see what i just did there) i would also like to know if you're adding more options to worldgenoverride to be able to make other prfeabs renewable as well? Currently a LOT of things like Ancient Guardian, different statues, clockwork monsters etc etc etc are not renewable and in Wilderness servers that becomes a huge issue.

I have been using "Fix Multiplayer" mod for the resource renewal code and i love the method used there, unfortunately that part of the mod is not working very well and/or occasionally causes crashes. My dream would be to see a proper way to be able to make EVERY single prefab renewable. (and i can't stress that enough... every single one, the ones not needed for renewal can be configured not to then)

That said, Wilderness servers start lagging eventually when certaint prefabs overrun the place, may they be monsters or items or whatever else. Which means there should be some method that would clean up items left on the ground after X (configurable value) amount of days, same goes for monsters, there should be an option to set a configurable limit to these.

 

ALSO, there is a bug with monkey, i don't have the error log anymore, but basically i think it happens when they start turning into shadowmonkeys.

 

Nevertheless, good job on the caves, absolutely love it.

The shadowmonkey thing will be fixed in the next release, thanks.

Concerning world renewal. As you may know there are some initial renewal features in the game, but we've just brushed the surface. The reason is, Don't Starve is all about certain kinds of scarcity. We've also tried to make the world very coherent within Maxwell's twisted image. Because of those two things, we're definitely not going to just periodically respawn everything. (It's important to us that if you destroy your world, it's destroyed! Otherwise what does anything matter at all?)

But that said, we've begun down a road of making things renew in ways that are thematically consistent and still make sense for gameplay. Many of the plants renew themselves, either by growing back in place or producing offspring -- because that's what plants do. For the rocks, we added the meteor showers, as something that's very periodic and noticeable, but carries some risks for the player as well. This is the kind of direction we're going to continue going down.

HOWEVER, if for your own worlds you just want everything to respawn, you can look into the way carrots and evergreens work (regrowthmanager and plantregrowth components). Regrowthmanager is really easy to add new regrowth types to (don't forget to set up the prefabs!) but plantregrowth is a little weird for modding...

Although we have some other priorities at the moment, if there are particular resources which naturally become very sparse late game, it's good to bring it up so we can focus on those ones first.

And to your other point, we also have plans to "clean up" long running worlds as well, but again it just hasn't been the most important thing yet. We are worried about it though!

Hope that helps!

[DejaVuZXY]

The shadowmonkey thing will be fixed in the next release, thanks.

Concerning world renewal. As you may know there are some initial renewal features in the game, but we've just brushed the surface. The reason is, Don't Starve is all about certain kinds of scarcity. We've also tried to make the world very coherent within Maxwell's twisted image. Because of those two things, we're definitely not going to just periodically respawn everything. (It's important to us that if you destroy your world, it's destroyed! Otherwise what does anything matter at all?)

But that said, we've begun down a road of making things renew in ways that are thematically consistent and still make sense for gameplay. Many of the plants renew themselves, either by growing back in place or producing offspring -- because that's what plants do. For the rocks, we added the meteor showers, as something that's very periodic and noticeable, but carries some risks for the player as well. This is the kind of direction we're going to continue going down.

HOWEVER, if for your own worlds you just want everything to respawn, you can look into the way carrots and evergreens work (regrowthmanager and plantregrowth components). Regrowthmanager is really easy to add new regrowth types to (don't forget to set up the prefabs!) but plantregrowth is a little weird for modding...

Although we have some other priorities at the moment, if there are particular resources which naturally become very sparse late game, it's good to bring it up so we can focus on those ones first.

And to your other point, we also have plans to "clean up" long running worlds as well, but again it just hasn't been the most important thing yet. We are worried about it though!

Hope that helps!

 

Thanks for responding and for the clarification. I understand what you mean by the world being coherent, but as there are different game mods, i believe the games "philosophy" changes as well when new gamemod is played. I can't play on any other game mod than Wilderness as in those, people nearly always die and mapwipes are very often to happen, which means 80% of the game content can never be explored. The Wilderness i love but the issue with resources running out is a problem (in my head at least) as the late joiners have pretty much nothing to do in the game world anymore, it's hard to survive and half the game content has simply "depleted" from the world.

 

That said, i do like the direction you are going with this game and you have all done a great job. Once the game mechanics and performance issues get sorted out and server clustering is tweaked (easier and more flexible configuration, portal connecting etc), i think the game has huge potential of becoming something really amazing.

 

Again, good job!

Edited November 25, 2015 by DejaVuZXY

[DejaVuZXY]

Hmm, the next issue is mod related... and to get them in a working order... Anyway yesterday we were talking to another modder and he ended up pushing another update to his mod, then this happened (mod is "Fix Multiplayer"):

 

(This is dedicated server error log)

Failure error code received: 404
[00:00:17]: With Body: <HTML><HEAD><TITLE>Error</TITLE></HEAD><BODY>
An error occurred while processing your request.<p>
Reference #25.4e2c8343.1448433918.1c8ccb93
</BODY></HTML>

 

Remember this guys? I think it's back again!

 

So yes, i can't download his mod and any new mods that were published to workshop as of yesterday and perhaps maybe even day before that. All the other mods that have not received an update are downloading fine.

Clientside error log is this when trying to download a mod which you have subscribed to:

 

[00:00:28]: DownloadPublishedFileV2()
[00:00:28]: Did not find the ugc handle in the cache. This is likely because you're subscribed to a non-existent file 503889043
[00:00:28]: DownloadPublishedFileV2()
[00:00:28]: OnDownloadPublishedFileResultV2
[00:00:28]:    EResult 2, 400055014014527857
[00:00:28]: Failed downloading mod!
[00:00:35]:    EResult 15, 503889043
[00:00:35]: Failed getting mod details.

 

If you just want to talk to me then you don't have to go these lengths to get me report bugs...

[Lumina]

A great thank for the bugs fix provided here. It's very very helpful.

 

 

 

But that said, we've begun down a road of making things renew in ways that are thematically consistent and still make sense for gameplay. Many of the plants renew themselves, either by growing back in place or producing offspring -- because that's what plants do. For the rocks, we added the meteor showers, as something that's very periodic and noticeable, but carries some risks for the player as well. This is the kind of direction we're going to continue going down.

 

Maybe some things could renew if the player do some actions in order to allow the process.

Like giving carrot to rabbit to make them reproduce (or fasten the process). (Rabbit are already renewable if i'm not wrong, it's just an example.)

 

Or you should make a empty beehive and release bee next to it in summer or autumn to hope they'll make a true beehive, but with the risk it became a wasphive.

[PeterA]

[00:00:28]: DownloadPublishedFileV2() [00:00:28]: Did not find the ugc handle in the cache. This is likely because you're subscribed to a non-existent file 503889043 [00:00:28]: DownloadPublishedFileV2() [00:00:28]: OnDownloadPublishedFileResultV2 [00:00:28]:    EResult 2, 400055014014527857 [00:00:28]: Failed downloading mod! [00:00:35]:    EResult 15, 503889043 [00:00:35]: Failed getting mod details.   If you just want to talk to me then you don't have to go these lengths to get me report bugs...

 

 

Are you still seeing issues with the mod downloading? I know that Valve was changing some servers on their side, so this may have been a temporary failure. I've tried reproducing the issue you're seeing but without any luck so far.

[DejaVuZXY]

 

 

Are you still seeing issues with the mod downloading? I know that Valve was changing some servers on their side, so this may have been a temporary failure. I've tried reproducing the issue you're seeing but without any luck so far.

 

 

Yes, it seems the issue is now solved.

[FerretAlpha]

Hello guys!

My problem is i dont hear woodcutting sounds. It appears every time i enable ANY mod. I verified game cache but everything was ok

[Kooky]

Hello guys!

My problem is i dont hear woodcutting sounds. It appears every time i enable ANY mod. I verified game cache but everything was ok

 

 

I get the same issue... but without mods. Really weird when this bug began for me because all I did was adjust some sound settings. I tried resetting back to default but that didn't work.