IBuildingConfig: modding empty methods crashes mac and linux (works on windows)

I can confirm the bug running on Linux with the aforementioned mod.

Also confirmed an issue on Fedora 30, causes crash on startup.

I believe this issue is an issue on Mono's end, because it doesn't work the same for methods with no IL body.  Some relevant GitHub issues on Harmony are an example of the bug and that Harmony only can patch methods with an IL body  Odds are that since the method is *declared* but is empty, Harmony attempts to patch it, which works on Windows, but Mono for Mac/Unix doesn't act the same way.

A potential fix is to make sure that all methods have at least a `return` or some other contents in the body?  I am not certain if the compiler would optimize that out though.

Actually, what I said above is incorrect.  The method is NOT empty, it contains a single byte `ret`.  Upon further investigation, the issue is narrowed down to this method in Harmony, which has comments saying that it's hacky and can fail on some platforms.  Someone with a lot of knowledge of C# internals would need to fix this in Harmony.  I think the issue is still related to method size, like Mono doesn't like to modify a region in memory less than a certain size, related to the funlockfile in the logs, but that is just a guess.

 

In the meantime, most buildings that don't have a DoPostConfigureComplete DO use a ConfigureBuildingTemplate that can normally be used for things like adding or modifying components.

Edited November 23, 2019 by asquared31415

Any development on this?

Quote

The problem here is that your newly created building will work, but your change will also apply to all other buildings not mentioning the method in question.

I had this affect my mods as well. Now I finally know why that happend. It might be possible to work around that issue by directly injecting the affected functions into BuildingConfigManager, but that is really messy and probably not compatibility friendly.