Jump to content

ACTIONFAIL_GENERIC quotes

Tykvesh

By Tykvesh

    • Closed

Not sure why this got closed without a reason.

Each character has a generic quote for failed action, but currently only Wilson's is used:

1387287817_DontStarveTogetherScreenshot2020_12.18-11_12_34_87.png.6385063a360d99b6c2169adc3ec1b046.png

Picture1.png.9cdfbd766cfd1d3572732d6e1093f474.png

Spoiler

function GetActionFailString(inst, action, reason)
    local character =
        type(inst) == "string"
        and inst
        or (inst ~= nil and inst.prefab or nil)

    local specialcharacter =
        type(inst) == "table"
        and ((inst:HasTag("playerghost") and "ghost") or
            (inst:HasTag("mime") and "mime"))
        or character

    local ret = GetSpecialCharacterString(specialcharacter)
    if ret ~= nil then
        return ret
    end

    character = string.upper(character)

    return (STRINGS.CHARACTERS[character] ~= nil and getcharacterstring(STRINGS.CHARACTERS[character].ACTIONFAIL, action, reason))
        or getcharacterstring(STRINGS.CHARACTERS.GENERIC.ACTIONFAIL, action, reason)
        or (STRINGS.CHARACTERS[character] ~= nil and STRINGS.CHARACTERS[character].ACTIONFAIL_GENERIC)
        or STRINGS.CHARACTERS.GENERIC.ACTIONFAIL_GENERIC
end

 

Steps to Reproduce
  1. Fail sweeping with the Clean Sweeper as Wilson
  2. Fail sweeping with the Clean Sweeper as anyone else
  • Like 3
  • Big Ups 1
Go to bugs

User Feedback


Tykvesh

Yet again? Can I at least hear a reasoning for Closing this? This is clearly a bug...

  • Like 2

Share this comment

Link to comment
Share on other sites
thegreatJash

What? Closing this bug thread? So it's intentional that they all have the same quotes as Wilson? Intentional or not, they should totally implement these quotes. 

Share this comment

Link to comment
Share on other sites
Well-met

I only now realize everyone uses wilson's string for this. Good find and i dont get why this is getting closed lmao

Edited by Well-met

Share this comment

Link to comment
Share on other sites
Tykvesh

I did. But I can't bring the fix with myself when playing on others' servers...

Klei prioritizing more important bugs like this one is understandable, but the solution is literally a line of code!

  • Like 1

Share this comment

Link to comment
Share on other sites
penguin0616

Why was this closed? There's a difference between leaving a report as pending and not doing anything with it verses closing it.

This was closed twice now, and no reasoning was given either time. I understand that it isn't reasonable to address every report with a closed or fixed, but if action is taken on a report's status, then I can't think of an excuse for not providing a few words of explanation on something that clearly appears to be a bug with the game.

This is the sort of action that causes reluctance in bug reporting.

Edited by penguin0616
  • Like 4

Share this comment

Link to comment
Share on other sites
Well-met

I have a custom character speech and I would sure like having the line I wrote be used properly for invalid actions

Share this comment

Link to comment
Share on other sites
Tykvesh

@thegreatJash Sorry about that, could you share your server logs after the error pops up?

Ow! You probably meant the link... Should be fixed now

Edited by Tykvesh
  • Like 1

Share this comment

Link to comment
Share on other sites
thegreatJash
10 hours ago, Tykvesh said:

@thegreatJash Sorry about that, could you share your server logs after the error pops up?

Ow! You probably meant the link... Should be fixed now

Works now. Thanks for the fix.

Share this comment

Link to comment
Share on other sites


Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

×
×
  • Create New...