help needed Code Sorting

[Fuffles]

Greetings,

I might have messed up some stuff in this code, could someone correct it?

 

Quote

local function followerWardrobe(inst, data, owner, self, costume, visuals)
    return function (inst, data)
        local function dressFollowerup(inst)
            if data and data.leader then
                local myownerskin = data.leader.components.skinner.skin_name
                
                if myownerskin == owner.."formal" then
                
                    inst.AnimState:SetBuild(self.."_formal")
                    
                elseif myownerskin == owner.."survivor" then
                
                    inst.AnimState:SetBuild(self.."_survivor")
                    
                elseif myownerskin == owner.."shadow" or myownerskin == owner.."unshadow" then
                
                    inst.AnimState:SetBuild(self.."_shadow")
                    
                elseif myownerskin == owner.."_"..costume or myownerskin == owner.."_"..costume.."_d" then
                
                    inst.AnimState:SetBuild(self.."_"..costume)
                    
                elseif myownerskin == owner.."_combatant" then
                
                    inst.AnimState:SetBuild(self.."_combatant")
                    
                elseif myownerskin == owner.."_gladiator" then
                
                    inst.AnimState:SetBuild(self.."_gladiator")
                    
                elseif myownerskin == owner.."_rose" then
                
                    inst.AnimState:SetBuild(self.."_rose")
                    
                elseif myownerskin == owner.."_ice" then
                
                    inst.AnimState:SetBuild(self.."_ice")
                    
                else
                    inst.AnimState:SetBuild(self.."_base")
                end
            end
        end
        
        inst:ListenForEvent("startfollowing", dressFollowerup)
    end
end

AddPrefabPostInit("abigail", function(inst)
    followerWardrobe(inst, data, "wendy", "ghost_abigail", "lureplant", false)
end)

 

[Ricoom]

??? that is nothing to go on... https://forums.kleientertainment.com/topic/73967-how-to-ask-help-for-modding-include-tutorials/

please read this and provide more info.

[CarlZalph]

In line 2 you're returning a function when I don't think you will.

 

Also you may like lookup tables instead of a giant if-then-else tree:

local skin_lookups = {
    formal = "_formal",
    survivor = "_survivor",
    shadow = "_shadow",
    unshadow = "_shadow",
    lureplant = "_lureplant",
    lureplant_d = "_lureplant",
    _combatant = "_combatant",
    _gladiator = "_gladiator",
    _rose = "_rose",
    _ice = "_ice",
}


myownerskin = myownerskin:sub(owner:len()+1)
local self_suffix = skin_lookups[myownerskin] or "_base"
inst.AnimState:SetBuild(self..self_suffix)