Jump to content

Sight-seeing module does grant bonus on return and does not show passengers on rocket screen


Soul-Burn
  • Branch: Live Branch Version: Windows Pending

I've made some sight-seeing module for rockets just for fun, thinking they would boost morale/stats/stress as stated in the wiki.

Unfortunately, dupes return without the bonus and naturally stressed due to low morale, like rocket pilots generally do.

It appears the game does not record dupes as passengers as seen the following images and the attached save file.

Note how the modules are assigned, but the passengers do not appear on the rocket screen. It stays that way also after the rocket is launched.

Once the rocket comes back, dupes fall from the module and do not gain the related bonuses.

20191223211838_1.jpg

20191223211847_1.jpg

I Lava Two.sav


Steps to Reproduce
Build rocket with sight-seeing module (without gantry). Assign dupes - should fly to the module. Look in rocket screen. Launch. On return, look for the buffs.



User Feedback


Update:

According to the source code, it seems sight-seeing module doesn't check if a gantry exist before unloading the dupe. ReleaseAstronaut is called immediately as the rocket lands, no giving enough time to even extend a gantry. Moreover, the buff is inside the conditional that the gantry exists and is extended.

Command module has a check for gantry (HasValidGantry) before calling ReleaseAstronaut. TouristModule is missing this check.

Share this comment


Link to comment
Share on other sites

Dupe reports, just doing some linky linky :)

Thanks for that info Soul-Burn, I hadn't looked at any code and assumed the issue was that the dupe in the sight-seeing module is unassigned from the module at landing, causing them to be ejected. Simply not having a gantry check in code would explain it nicely lol

If you leave the gantry extended during landing and let the rocket smash through it, the sight-seer can exit safely btw <3

Share this comment


Link to comment
Share on other sites

What happened to the quotes in this forum?
In my post there were completely different screenshots.

1148610587_2020-11-1718-20-20.thumb.png.5bddc09bc1c58b597ffa27a1def1295f.png

@outseeker Please make a new bug report.
Klei usually doesn't read old bug reports.

Share this comment


Link to comment
Share on other sites

Hello. After wondering a lot why the "visited space" buff weren't working, I found this thread here... And it seems like the bug still exists. My dupes wont receive the buff unless I sacrifice a bunch of gantries while landing.

 

It's too bad to me since I'm playing with 20 dupes and made a rocket with 10 sight seeing modules (since I wanted to be able to buff everybody with only two trips), i can't sacrifice a dozen of gantries each trip for this buff to work..

 

So.. after almost a whole year after the last answer on this thread, are there any plans for the developers to fix this old bug?

Share this comment


Link to comment
Share on other sites



Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

×
  • Create New...