Sea Weed's will attack nearby players when ignited even if said ignition was NOT caused by a player.

This should stop Sea Weeds from becoming aggresive when being ignited from smoldering:

• Make so Burnable's SmolderUpdate uses self.inst as source for Ignite: 

  local function SmolderUpdate(inst, self)
  	< ... >
  
  	self.smoldertimeremaining = self.smoldertimeremaining - SMOLDER_TICK_TIME * heatmod
  	if self.smoldertimeremaining <= 0 then
  		self:StopSmoldering() --JUST in case ignite fails...
  		self:Ignite(nil, self.inst) --smoke is invalid at this point, so use self.inst as source
  
  	< ... >
  end

• Don't forget to pass source to "onignite" event: 

  function Burnable:Ignite(immediate, source, doer)
  	if not (self.burning or self.inst:HasTag("fireimmune")) then
  		self:StopSmoldering()
  
  		self.burning = true
  		self.inst:ListenForEvent("death", OnKilled)
  		self:SpawnFX(immediate)
  
  		self.inst:PushEvent("onignite", { source = source, doer = doer })
  		
  		< ... >
  	end
  end

• And finally, make use of these changes in waterplant prefab: 

  local function on_ignited(inst, data)
  	-- Would be nice to use data.doer, but very few places seem to pass it!
  	-- So just set the closest player as a target and assume they lit us up.
  	if data ~= nil and data.source ~= inst then
  		find_and_attack_nearby_player(inst)
  	end
  
  	inst.components.harvestable:Disable()
  end

   

Edited November 30, 2021 by Tykvesh

I understand that the on_ignited comment, as it exists in the script, gives a certain impression of why the script is written as it is. The mistake here was that comment not being re-written before the update's release. I can assure you that the burning behaviour was a discussed piece of design feedback at the time.

I cannot promise that we will make the changes in the above comment, or change the design of the Sea Weed catching on fire, but I will take this bug report as design feedback, and rewrite the on_ignited comment for a future change.

Thank you for the report!

9 minutes ago, StevenM said:

I understand that the on_ignited comment, as it exists in the script, gives a certain impression of why the script is written as it is. The mistake here was that comment not being re-written before the update's release. I can assure you that the burning behaviour was a discussed piece of design feedback at the time.

I cannot promise that we will make the changes in the above comment, or change the design of the Sea Weed catching on fire, but I will take this bug report as design feedback, and rewrite the on_ignited comment for a future change.

Thank you for the report!

I appreciate your response a lot, thank you for your work!