[General] - avatars.xml and playerbadge.lua misreferences

[rezecib]

Bug Submission:

Category: General
Issue Title: avatars.xml and playerbadge.lua misreferences
Issue Description:

playerbadge.lua is set to look for player avatars as "avatar_" .. prefab and "avatar_ghost_" .. prefab, but ghost Wendy and ghost Wigfrid are not properly labeled like that in avatars.xml.

 

For some reason playerbadge.lua has an exception where it looks differently for Wendy's ghost avatar:

    if self.isGhost then        self.headbg:SetTexture("images/avatars.xml", "avatar_ghost_bg.tex")        if target.badgename == "wendy" then            self.head:SetTexture("images/avatars.xml", "avatar_ghost_player"..target.badgename..".tex")        else            self.head:SetTexture("images/avatars.xml", "avatar_ghost_"..target.badgename..".tex")        end    end

However, avatars.xml has an "avatar_ghost_wendy" with a red flower, and an "avatar_ghost_wendyplayer" with a yellow flower (I think this is intended to be "avatar_ghost_playerwendy"). It makes more sense for me to just switch "avatar_ghost_wendyplayer" and "avatar_ghost_wendy", and then the if-then-else in playerbadge could be removed.

 

Additionally, avatars.xml has Wigfrid's ghost as "avatar_ghost_wigfrid", but her prefab is wathgrithr (and her normal avatar is "avatar_wathgrithr"), so that will cause problems in the future.

 

Steps to Reproduce: This isn't important.

[SethR]

Friends don't let friends code tired--good catch

[rezecib]

@SethR I code tired all the time... With disastrous results on occasion, definitely. I guess that means I need better friends xD

[SethR]

Haha, that was _mostly_ in jest/an excuse for the mistake 

 

 

... I may or may not have been up until 2:30 last night working on a game for 7DFPS. Who knows what kind of fun bugs I introduced into that game!