Jump to content

KAnimControllerBase Play Queue broken binary compatibility with some mods


Sanchozz
  • Branch: Preview Branch Version: Linux Fixed

"It's never happened before, and now it's happening again" (c)

A new parameter "requester" with a default value of == null has been added to the "Play" and "Queue" methods of the "KAnimControllerBase" class, and this parameter is de facto not even used for anything anywhere.

This has again broken binary compatibility with all mods that use these methods to play animations.

KAnimControllerBase.Queue.png.e07aa26c7692fcede7fc393a6507b58b.png


Steps to Reproduce

see Description

  • Like 1



User Feedback


A developer has marked this issue as fixed. This means that the issue has been addressed in the current development build and will likely be in the next update.

it looks fixed. Thank you.

But I found one more thing.
let's take a look at the Klei.AI.Effects class.
methods such as Add, Get, HasEffect, Remove are available in three variants.
For example, the Add methods was previously:

public EffectInstance Add(string effect_id, bool should_save);
public EffectInstance Add(HashedString effect_id, bool should_save);
public EffectInstance Add(Effect newEffect, bool should_save);

But now one of the Add methods has received a third parameter "resolveTooltipCallback" with a default value of == null 

Please, in order to maintain binary compatibility with many mods, add the Add method with two parameters. for example, something like this:

public EffectInstance Add(Effect newEffect, bool should_save)
{
    Add(newEffect, should_save, null);
}

thank you in advance

Share this comment


Link to comment
Share on other sites

6 hours ago, EricKlei said:

Could you provide an example mod that was crashing?

just as an example

Rover's Recharger crash when charging starts

More Emotions crash when the duplicant reacts near the tombstone

of course, I could easily recompile and reupload them.

but I'm pretty sure there are other mods in the workshop that are also affected. the authors of which do not have the opportunity to recompile and reupload now.

  • Like 2

Share this comment


Link to comment
Share on other sites



Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

×
  • Create New...