Jump to content

Pump fails to check mass

Risu

By Risu

    • Fixed

In Storage.GetAnyLiquidChunk() there are no checks for mass so it returns the first element found.

ConduitDispenser.ConduitUpdate(float) uses that method and then checks that the mass found is greater than 0. If it is 0 it does nothing, but that 0 mass element remains in the storage.

Therefore it will only continue work once that first element receives more mass.

 

Steps to Reproduce
Have a pump doing anything at all.
  • Like 2
Go to bugs

User Feedback


A developer has marked this issue as fixed. This means that the issue has been addressed in the current development build and will likely be in the next update.
Risu

I decided to patch a check for mass greater than 0 into Storage.GetAnyLiquidChunk()

Would appear to be correct.
 

20170221163610_1.jpg

  • Like 2

Share this comment

Link to comment
Share on other sites
ReanaTheRogue

This sounds similar to the gas pump getting stuck on one gas.  Could there be a similar check missing for gases?  It would also explain why reloading fixes it since the 0.0 kg gas is removed on reload.

Share this comment

Link to comment
Share on other sites


Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

×
×
  • Create New...