Copying setting through valve doesn't work.


OxCD
  • Branch: Live Branch Version: Windows Pending

Hi.

Copying setting on different valves doesn't work. It's says that the valve has taken into account the modification, it says it only waits for the dup to change the setting, but dups never come until you manually set the number again, for each valve.


Steps to Reproduce
Build two valve. Send liquid through those. set one to 1kg/s for example. Copy setting, paste one the other valve. Dups never come to change the new setting. Manually set this second one to 1kg/s, and the dup will come.

Status: Pending

This issue has not been confirmed by a developer yet.


  Report Bug


User Feedback


....

Looks fairly trivial to fix. Valve.OnCopySettings() sets this.desiredFlow, but doesn't add chores. If it instead calls this.ChangeFlow( component.desiredFlow), then ChangeFlow should set this.desiredFlow and make a chore if needed.

I didn't test this though as that would require me to set up a new mod and start having fun with harmony. It seems a lot easier to test quickly if you have access to the real game code instead of just harmony patching. As with any other untested solution proposal, it can't be ruled out that something unexpected happens when testing.

Edited by Nightinggale

Share this comment


Link to comment
Share on other sites


Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now