Fused Shadelings Don't Deal Damage When They Do Their Big Jump Attack

I guess it's intentional, it's a displacement rather than an attack. It even resets the Fused Shadeling's normal attack cooldown.

Since this is closed, I guess it's intentional? @V2C

I didn't understand why they were jumping, hence why I made the report.

Edited June 7, 2023 by lakhnish

I initially guessed it could be intentional, but after looking at the code, it just looks like the attack attempt is blocked by the jump_pst state containing the "busy" tag, and it not being removed right before doing said attempt.

That and also the timeout on the jump_pst state is a bit too long, so even if the "busy" issue was fixed, it would be almost the same as how it currently works, where the shadeling stands still for a bit, then exits the jump_pst state, and then starts a standard attack. Do note, the attack at the end of the jump is exactly the same as a normal attack, it's not a unique one.

If it's intentional to be a way for them to close the distance to a target, it should probably be a bit more clear in code, and the timeout could be revised a bit. Right now it looks like an oversight instead.

I personally changed the ontimeout function to just go to idle (as well as reduced the timeout time a bit), and the second timeline event attempts to do the attack at the end of its function (as well as removing the busy tag prior to it), and it works pretty smoothly. This could be done without the attack part if they wish to keep it as a displacement ability without the shadeling standing in place for as long as they do currently.

Edited March 15, 2024 by hoxi
A few details