[General] - Scoreboard breaks mod characters when brought up (solution proposed)

[rezecib]

Bug Submission:

Category: General
Issue Title: Scoreboard breaks mod characters when brought up (solution proposed)
Issue Description: Bringing up the scoreboard overwrites the prefab of any characters that aren't in DST_CHARACTERLIST due to a certain block in playerbadge.lua

This causes many things about modded characters to break on bringing up the scoreboard (or having another player join), including the ability to use character-specific items, have the correct examine quotes, and more.

This could be fixed by storing the prefab name that's being used for the badge icon tex's locally, instead of overwriting target.prefab.

Steps to Reproduce:
Have a modded character.

Examine something.

Bring up the scoreboard.

Examine the thing again and observe Wilson's quote.

 

Edit: Here's a modified playerbadge.lua that shows the fix. playerbadge.lua.txt

[SethR]

Doh! Silly mistake on my part. I'll put a fix for this into our next hotfix. Thanks for the report!

[SethR]

Looks like the same issue exists in targetindicator.lua too (which is the widget that gets used for the edge-of-screen indicators). I don't think my fix there made it into the build we're testing now, but it'll be in the next patch. Sorry for the disruption!