Natural gas generator not producing output at the correct temperature

Also the minimum output temperature of 40 C is not being applied to the polluted water.

 

Bump?

I ran across something while digging through code while looking at modding something semi-related, and I noticed that when the natural gas generator (and other generators that produce piped/ducted outputs) generate an output, they seem to use (from EnergyGenerator.cs):

 

 if (output.store)
    {
      if (elementByHash.IsGas)
        this.storage.AddGasChunk(output.element, num1, root_pe.Temperature, byte.MaxValue, 0, true);
      else if (elementByHash.IsLiquid)
        this.storage.AddLiquid(output.element, num1, root_pe.Temperature, byte.MaxValue, 0, true);

root_pe.Temperature appears to be the temperature of the building.

 

Shouldn't root_pe.Temperature be replaced with something that clamps it to at least 110C?

When outputting liquid pwater, it at least uses

      float temperature = Mathf.Max(root_pe.Temperature, output.minTemperature);
....
          FallingWater.instance.AddParticle(num2, elementIndex, num1, temperature, byte.MaxValue, 0, true);

which appears that it should be coming out at a minimum of the specified temperature.

 

Edited January 13, 2024 by ashridah

On 1/13/2024 at 12:11 PM, ashridah said:

I ran across something while digging through code while looking at modding something semi-related, and I noticed that when the natural gas generator (and other generators that produce piped/ducted outputs) generate an output, they seem to use (from EnergyGenerator.cs):

This is exactly what's causing the bug. In EnergyGenerator.Emit() the branch of the code that places the element in the building's storage for emission into output pipe isn't clamping the temperature to be the max of the building's PrimaryElement and the OutputItem's minTemperature. It is correctly doing that clamping for the branch that emits to the environment. The fix is easy.

 

private void Emit(EnergyGenerator.OutputItem output, float dt, PrimaryElement root_pe)
{
	Element element = ElementLoader.FindElementByHash(output.element);
	float num = output.creationRate * dt;
	float temperature = Mathf.Max(root_pe.Temperature, output.minTemperature); // This line moved from inside environment-emission branch
	if (output.store)
	{
		if (element.IsGas)
		{
			this.storage.AddGasChunk(output.element, num, temperature, byte.MaxValue, 0, true, true); // Change root_pe.Temperature to temperature variable
			return;
		}
		if (element.IsLiquid)
		{
			this.storage.AddLiquid(output.element, num, temperature, byte.MaxValue, 0, true, true); // Change root_pe.Temperature to temperature variable
			return;
		}
		GameObject go = element.substance.SpawnResource(base.transform.GetPosition(), temperature, byte.MaxValue, 0, false, false, false); // Change root_pe.Temperature to temperature variable
		this.storage.Store(go, true, false, true, false);
		return;
	}
	else
	{
		int num2 = Grid.OffsetCell(Grid.PosToCell(base.transform.GetPosition()), output.emitOffset);
// 		float temperature = Mathf.Max(root_pe.Temperature, output.minTemperature);	// Moved to above
		if (element.IsGas)	// Code continues unchanged from here

 

This only generator this seems to affect (that currently exists in game) is the Natural Gas Generator; all others emit to their environment, so are clamping temperature correctly.

Edited January 23, 2025 by Vertel

Example natural gas generator at -30 C. Consumes natural gas at 26.9 C. Outputs CO2 at -30 C.

This problem has existed for a while.

For what it's worth, this bug will get fixed on the next StockBugFix mod update, as an optional setting: https://github.com/peterhaneve/ONIMods/issues/503

Edited August 15, 2024 by b l a n k