Jump to content

Watering can failed to "failed to fill with ocean water"

LaoWang27

By LaoWang27

    • Pending

Watering can failed to fill with ocean water, Action-failed string was not said out. Actually, the action was skipped in mastersim.

No log file as this bug doesn't crash the game :p

--------------------------------------------------------------------------------------------------------------------------------------------------------------------------

 

A Gif may help understanding what I mean.

Before Fixing:

1.gif.2e2bee467e84e0c3634f41ed444ea0f7.gif

2.gif.7d2d5cefd40749f2d8e40650a4370fd8.gif

 

After Fixing:

fix1.gif.7b8bb397ca4cabc27ea18c1ebd02cf33.gif

fix2.gif.43334d75ffe67dc149cde34317eed2fa.gif

--------------------------------------------------------------------------------------------------------------------------------------------------------------------------

To fix it:

components/playeractionpicker.lua Line 264: 

--function PlayerActionPicker:GetRightClickActions(...)
--... Line 264
    if actions == nil and target == nil and ispassable then
        if equipitem ~= nil and equipitem:IsValid() then
            --can we use our equipped item at the point?
            actions = self:GetPointActions(position, equipitem)
            --this is to make it so you don't auto-drop equipped items when you left click the ground. kinda ugly.
            if actions ~= nil then
                for i, v in ipairs(actions) do
                    if v.action == ACTIONS.DROP then
                        table.remove(actions, i)
                        break
                    end
                end
            end
        end
        if actions == nil or #actions <= 0 then
            actions = self:GetPointSpecialActions(position, useitem, false)
        end
    end

    return actions or {}
end

Could be changed to: 

if actions == nil and target == nil and equipitem ~= nil and equipitem:IsValid() then
        if ispassable or equipitem:HasTag("fillable_showoceanaction") --[[ allow action on impassable so that I can click ocean and fill watering can ]] then
            --can we use our equipped item at the point?
            actions = self:GetPointActions(position, equipitem)
            --this is to make it so you don't auto-drop equipped items when you left click the ground. kinda ugly.
            if actions ~= nil then
                for i, v in ipairs(actions) do
                    if v.action == ACTIONS.DROP then
                        table.remove(actions, i)
                        break
                    end
                end
            end
        end
        if actions == nil or #actions <= 0 then
            actions = self:GetPointSpecialActions(position, useitem, false)
        end
    end

    return actions or {}
end

 

Steps to Reproduce

1. Run a server with cave

2. Enable movement prediction

3. Drag an empty watering can on ocean and left click

 

  • Like 1
Go to bugs

User Feedback


Hornete
23 hours ago, i am a person said:

ocean water is too salty

they even made a quote i mean you just can't it's not a bug

You didnt understand the bug. The quote isnt being said properly.

  • Like 1

Share this comment

Link to comment
Share on other sites


Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

×
×
  • Create New...