Need Help Fixing Mod

[fayescarlet64]

There is a Dipper Pines mod on the Steam Workshop and it has a few issues. I decided to take it upon myself to try and fix it, because the maker of the mod doesn't seem interested in people's comments or my log report of the problem.

 

Here is the mod I am trying to fix: http://steamcommunity.com/sharedfiles/filedetails/?id=372911249

 

The main issue is a journal item referred to in the files as "gfbook3", if it's in the server in any way at all, the player who is Dipper cannot return to the game, even if they're the host. They're just stuck on the loading screen.

 

The console always says the same thing:

Warning! GetPlayer() is deprecated. Please use ThePlayer instead.

 

 

Here is the error code that happens when you try to reenter a server with the journal not deleted.

[03:26:13]: Warning: GetPlayer() is deprecated. Please use ThePlayer instead. (@../mods/workshop-372911249/scripts/prefabs/gfbook3.lua:12 in changetree) [03:26:13]: [string "../mods/workshop-372911249/scripts/prefabs/..."]:12: attempt to index a nil valueLUA ERROR stack traceback:../mods/workshop-372911249/scripts/prefabs/gfbook3.lua:12 in (upvalue) changetree (Lua) <9-22>inst = 107943 - (valid:true)sci = nilmag = nilanc = nil../mods/workshop-372911249/scripts/prefabs/gfbook3.lua:74 in (field) fn (Lua) <43-78>inst = 107943 - (valid:true)scripts/mainfunctions.lua:148 in () ? (Lua) <137-168>name = gfbook3prefab = Prefab gfbook3 - =[C]:-1 in (method) SpawnPrefab (C) <-1--1>scripts/mainfunctions.lua:182 in (global) SpawnPrefab (Lua) <179-184>name = gfbook3scripts/mainfunctions.lua:189 in (global) SpawnSaveRecord (Lua) <186-224>saved = table: 0C99B880newents = table: 2A7E49E8scripts/gamelogic.lua:413 in (upvalue) PopulateWorld (Lua) <234-448>savedata = table: 212977C0profile = table: 354DA630world = 100024 - forest (valid:true)retune = table: 2A7E33E0newents = table: 2A7E49E8prefab = gfbook3ents = table: 0C99B470prefab = gfbook3k = 1v = table: 0C99B880scripts/gamelogic.lua:639 in (upvalue) DoInitGame (Lua) <527-741>savedata = table: 212977C0profile = table: 354DA630was_file_load = falsescripts/gamelogic.lua:773 in (upvalue) cb (Lua) <768-774>savedata = table: 212977C0scripts/saveindex.lua:124 in () ? (Lua) <106-125>load_success = truestr = return {world_network={persistdata={clock={moonphase="new",cycles=1,phase="day",remainingtimeinphase=354.43548583984,totaltimeinphase=360,segs={night=1,day=12,dusk=3}},seasons={elapseddaysinseason=1,premode=false,remainingdaysinseason=29,lengths={summer=10,autumn=30,spring=20,winter=22},totaldaysinseason=60,mode="cycle",season="autumn",segs={summer={night=4,day=11,dusk=1},autumn={night=2,day=8,dusk=6},spring={night=3,day=5,dusk=8},winter={night=6,day=5,dusk=5}}},weather={seasontemperature=29.166666666667,preciptype="none",daylight=true,moistureceil=874.52374267578,peakprecipitationrate=1,season="autumn",moisturerateval=0.25102779511949,lightningmode="rain",moistureceilmultiplier=8,moisture=121.39041900635,stopsnowthreshold=0,snowlevel=0,moisturefloormultiplier=1,moisturerateoffset=0,noisetime=485.53634643555,moisturerate=0.25102779269218,wetness=0,nextlightningtime=5,startsnowthreshold=-5,precipmode="dynamic",moisturefloor=0,moistureratemultiplier=1,phasetemperature=0.24270211912433}}},super=true,ents={beefal [**truncated**]success = truesavedata = table: 212977C0=[C]:-1 in (method) GetPersistentString (C) <-1--1>scripts/saveindex.lua:106 in (method) GetSaveDataFile (Lua) <105-126>self =data = table: 354DA658current_slot = 1file = session/00B0001A00DC4FD2/0000000003cb = function - scripts/gamelogic.lua:768[03:26:13]: [string "../mods/workshop-372911249/scripts/prefabs/..."]:12: attempt to index a nil valueLUA ERROR stack traceback:../mods/workshop-372911249/scripts/prefabs/gfbook3.lua:12 in (upvalue) changetree (Lua) <9-22>../mods/workshop-372911249/scripts/prefabs/gfbook3.lua:74 in (field) fn (Lua) <43-78>scripts/mainfunctions.lua:148 in () ? (Lua) <137-168>=[C]:-1 in (method) SpawnPrefab (C) <-1--1>scripts/mainfunctions.lua:182 in (global) SpawnPrefab (Lua) <179-184>scripts/mainfunctions.lua:189 in (global) SpawnSaveRecord (Lua) <186-224>scripts/gamelogic.lua:413 in (upvalue) PopulateWorld (Lua) <234-448>scripts/gamelogic.lua:639 in (upvalue) DoInitGame (Lua) <527-741>scripts/gamelogic.lua:773 in (upvalue) cb (Lua) <768-774>scripts/saveindex.lua:124 in () ? (Lua) <106-125>=[C]:-1 in (method) GetPersistentString (C) <-1--1>scripts/saveindex.lua:106 in (method) GetSaveDataFile (Lua) <105-126>[03:26:13]: SCRIPT ERROR! Showing error screen [03:26:13]: SpawnSaveRecord [nil, gfbook3] FAILED

 

So I changed all instances of "GetPlayer" to "ThePlayer" hoping that would fix the problem, but it is not the case. Here is the error code I got:

 

[00:01:58]: [string "../mods/workshop-372911249/scripts/prefabs/..."]:12: attempt to call global 'ThePlayer' (a table value)LUA ERROR stack traceback:../mods/workshop-372911249/scripts/prefabs/gfbook3.lua:12 in (upvalue) changetree (Lua) <9-22>   inst = 114942 -  (valid:true)   sci = nil   mag = nil   anc = nil../mods/workshop-372911249/scripts/prefabs/gfbook3.lua:74 in (field) fn (Lua) <43-78>   inst = 114942 -  (valid:true)scripts/mainfunctions.lua:148 in () ? (Lua) <137-168>   name = gfbook3   prefab = Prefab gfbook3 - =[C]:-1 in (method) SpawnPrefab (C) <-1--1>scripts/mainfunctions.lua:182 in (global) SpawnPrefab (Lua) <179-184>   name = gfbook3scripts/prefabs/player_common.lua:1633 in (method) OnNewSpawn (Lua) <1629-1641>   i = 1   v = gfbook3scripts/networking.lua:120 in () ? (Lua) <113-126>   player_guid = 114163   skin_name = nil   player = 114163 - dipper (valid:true)=[C]:-1 in (method) SendSpawnRequestToServer (C) <-1--1>scripts/mainfunctions.lua:1216 in (local) cb (Lua) <1214-1217>scripts/frontend.lua:523 in (method) DoFadingUpdate (Lua) <487-527>   self =      tracking_mouse = true      fade_title_out = false      overlayroot = overlayroot      screenroot = screenroot      save_indicator_fade_time = 0      topwhiteoverlay = Image - images/global.xml:square.tex      helptextbg = Image - images/global.xml:square.tex      helptext = HelpText      subtitle = Text -       updating_widgets_alt = table: 11566288      spinner_repeat_time = -1      helptexttext = Text -       scroll_repeat_time = -1      vigoverlay = Image - images/bg_vignette.xml:vignette.tex      topFadeHidden = false      gameinterface = 100016 -  (valid:true)      updating_widgets = table: 22123C00      lastx = 1087      topblackoverlay = Image - images/global.xml:square.tex      total_fade_time = 1      lasty = 212      focus_locked = false      autosave_enabled = true      whiteoverlay = Image - images/global.xml:square.tex      blackoverlay = Image - images/global.xml:square.tex      screenstack = table: 0DCDAE90      displayingerror = false      topvigoverlay = Image - images/bg_vignette.xml:vignette.tex      fade_type = white      saving_indicator = UIAnim      fade_time = 1.0000153724104      alpha = 1      consoletext = Text - CONSOLE TEXT      num_pending_saves = 0      fade_title_in = false      forceProcessText = false      fade_title_time = 0      save_indicator_time_left = 0      repeat_time = 0      title = Text -    dt = 0.016666797921062   alpha = 1   cb = function - scripts/mainfunctions.lua:1214scripts/frontend.lua:575 in (method) Update (Lua) <535-684>   self =      tracking_mouse = true      fade_title_out = false      overlayroot = overlayroot      screenroot = screenroot      save_indicator_fade_time = 0      topwhiteoverlay = Image - images/global.xml:square.tex      helptextbg = Image - images/global.xml:square.tex      helptext = HelpText      subtitle = Text -       updating_widgets_alt = table: 11566288      spinner_repeat_time = -1      helptexttext = Text -       scroll_repeat_time = -1      vigoverlay = Image - images/bg_vignette.xml:vignette.tex      topFadeHidden = false      gameinterface = 100016 -  (valid:true)      updating_widgets = table: 22123C00      lastx = 1087      topblackoverlay = Image - images/global.xml:square.tex      total_fade_time = 1      lasty = 212      focus_locked = false      autosave_enabled = true      whiteoverlay = Image - images/global.xml:square.tex      blackoverlay = Image - images/global.xml:square.tex      screenstack = table: 0DCDAE90      displayingerror = false      topvigoverlay = Image - images/bg_vignette.xml:vignette.tex      fade_type = white      saving_indicator = UIAnim      fade_time = 1.0000153724104      alpha = 1      consoletext = Text - CONSOLE TEXT      num_pending_saves = 0      fade_title_in = false      forceProcessText = false      fade_title_time = 0      save_indicator_time_left = 0      repeat_time = 0      title = Text -    dt = 0.016666797921062[00:01:58]: [string "../mods/workshop-372911249/scripts/prefabs/..."]:12: attempt to call global 'ThePlayer' (a table value)LUA ERROR stack traceback:    ../mods/workshop-372911249/scripts/prefabs/gfbook3.lua:12 in (upvalue) changetree (Lua) <9-22>    ../mods/workshop-372911249/scripts/prefabs/gfbook3.lua:74 in (field) fn (Lua) <43-78>    scripts/mainfunctions.lua:148 in () ? (Lua) <137-168>    =[C]:-1 in (method) SpawnPrefab (C) <-1--1>    scripts/mainfunctions.lua:182 in (global) SpawnPrefab (Lua) <179-184>    scripts/prefabs/player_common.lua:1633 in (method) OnNewSpawn (Lua) <1629-1641>    scripts/networking.lua:120 in () ? (Lua) <113-126>    =[C]:-1 in (method) SendSpawnRequestToServer (C) <-1--1>    scripts/mainfunctions.lua:1216 in (local) cb (Lua) <1214-1217>    scripts/frontend.lua:523 in (method) DoFadingUpdate (Lua) <487-527>    scripts/frontend.lua:575 in (method) Update (Lua) <535-684>    scripts/update.lua:93 in () ? (Lua) <39-123> [00:01:58]: SCRIPT ERROR! Showing error screen [00:02:11]: Shutdown: shutting up talker [00:02:11]: unloading prefabs for mod MOD_workshop-365119238 [00:02:11]: unloading prefabs for mod MOD_workshop-376333686 [00:02:11]: unloading prefabs for mod MOD_workshop-343753877 [00:02:11]: unloading prefabs for mod MOD_workshop-372911249 [00:02:11]: unloading prefabs for mod MOD_workshop-416991215 [00:02:11]: unloading prefabs for mod MOD_workshop-356398534 [00:02:11]: unloading prefabs for mod MOD_workshop-453693119 [00:02:11]: unloading prefabs for mod MOD_workshop-347360448 [00:02:11]: unloading prefabs for mod MOD_workshop-345692228 [00:02:11]: unloading prefabs for mod MOD_workshop-352373173 [00:02:11]: unloading prefabs for mod MOD_workshop-351325790 [00:02:11]: Left room 109775242309647785[00:02:11]: Collecting garbage...[00:02:11]: lua_gc took 0.12 seconds[00:02:11]: ~NetworkLuaProxy()[00:02:11]: ~SimLuaProxy()[00:02:11]: SteamWorkshop::CancelDownloads clearing all unfinished downloads[00:02:11]: lua_close took 0.27 seconds[00:02:12]: [Steam] Auth ticket cancelled[00:02:12]: Orphaned unnamed resource. This resource must have used Add( resource ) to insert itself into the manager. [00:02:12]: Orphaned unnamed resource. This resource must have used Add( resource ) to insert itself into the manager. [00:02:12]: Orphaned unnamed resource. This resource must have used Add( resource ) to insert itself into the manager. [00:02:12]: Orphaned unnamed resource. This resource must have used Add( resource ) to insert itself into the manager. [00:02:12]: Orphaned unnamed resource. This resource must have used Add( resource ) to insert itself into the manager. [00:02:12]: HttpClient2::ClientThread::Main() complete[00:02:12]: Shutting down

[fayescarlet64]

I love this mod and want to use it without all these things breaking and stuff. Any and all help would be appreciated, especially since it seems I still need some pointers so I can make my own mod.

[DarkXero]

@fayescarlet64, how the component works is weird.

I think I got it.

Shouldn't crash with the journal 3.

 

The other journals didn't spawn for me, and they are also the same as 3, so I didn't touch them.

Dippers.zip

[fayescarlet64]

Ohh, wow, this is cool, @DarkXero! Er, so I would just replace the current mod files with your files, right? Wanna make sure so I don't break anything..

[DarkXero]

@fayescarlet64, yeah.

The only thing that may break the mod is spawning a gfbook2 or gfbook1, but those are just gfbook3.

Those books can't spawn naturally.

 

Or they should and it was already broke and I couldn't get them to spawn. Anyway...

[fayescarlet64]

I see, this is perfect, wow! Thank you, you're amazing! 8D; Now I don't need to delete the journal anymore.

 

Is it possible to explain how you did it? I want to know for when I get to making my own mods sometime.

[DarkXero]

Is it possible to explain how you did it?

 

I removed the components and started from scratch, from the idea to have the book give you tech access.

 

Now the gfbook3, on pickup, gives tech bonuses and stores the owner entity, if the owner has a special tag that only Dippers has.

That way, on dropping the book, the owner holding it loses the bonuses.

 

The rest is the same.

[fayescarlet64]

I removed the components and started from scratch, from the idea to have the book give you tech access.

 

Now the gfbook3, on pickup, gives tech bonuses and stores the owner entity, if the owner has a special tag that only Dippers has.

That way, on dropping the book, the owner holding it loses the bonuses.

 

The rest is the same.

 

I ran into a problem. 8D; The thing is telling me I need to use a Shadow Manipulator to build even stuff like Wooden Flooring, etc. But even when the Shadow Manipulator is built, it still won't allow me to build anything.

[DarkXero]

@fayescarlet64, it's a Klei side bug given how the tooltips are generated based on the bonuses.

Then again, nothing grants 1, 2, 2 bonuses at the same time.

Should say alchemy engine instead of shadow manipulator.

You can avoid this confusion by upping the science_bonus to 2, instead of 1, I suppose.

[fayescarlet64]

Oh gosh, I see. Thanks man. 8D; Truly, you've been a MAJOR help! I appreciate it!