[General] - Wrong item examination description bug


Some1

Recommended Posts

Bug Submission:

Category: General

Issue Title: Wrong item examination description bug

Issue Description: Items have wrong examination description in certain conditions.

If some fixable item have no description for some player, but he's able to fix it, then this player will say GENERIC description + GENERIC ANNOUNCE_CANFIX, despite he have his own ANNOUNCE_CANFIX speech.

For example:

Player Wx78 has its own ANNOUNCE_CANFIX ("\nI CAN FIX THIS.") but have no description for WALL_MOONROCK.

His examination string would be equivalent to Wilson's one, but in my opinion it should be build from Wilson's default as first part + Wx's ANNOUNCE_CANFIX.

 

I think, it should be somewhere in stringsutil.lua:

 

    if not ret and STRINGS.CHARACTERS[character] then        ret = getcharacterstring(STRINGS.CHARACTERS[character].DESCRIBE, itemname, modifier)        if ret and item and item.components.repairable and item.components.repairable:NeedsRepairs() then            ret = ret..getcharacterstring(STRINGS.CHARACTERS[character], "ANNOUNCE_CANFIX", modifier)        end    end    if not ret then        ret = getcharacterstring(STRINGS.CHARACTERS.GENERIC.DESCRIBE, itemname, modifier)        if item and item.components.repairable and item.components.repairable:NeedsRepairs() then            if not ret then ret = "" end            ret = ret..getcharacterstring(STRINGS.CHARACTERS.GENERIC, "ANNOUNCE_CANFIX", modifier)        end    end
Steps to Reproduce: Play Wx78, spawn WALL_MOONROCK, examine it.
Link to comment
Share on other sites

Archived

This topic is now archived and is closed to further replies.

Please be aware that the content of this thread may be outdated and no longer applicable.