Some entities play looping sounds even when unloaded

From what I was able to find at least:

• deerclopseyeball_sentryward (only when an eye is placed on it)
• lightflier
• batcave

deerclopseyeball_sentryward simply lacks OnEntityWake and OnEntitySleep functions to handle its ambience sound (as well as a not asleep check for OnEyeballGiven before playing the sound).

In lightflier.lua:

    inst.SoundEmitter:PlaySound("grotto/creatures/light_bug/fly_LP", "loop")

This is playing on entity creation.

The EnableBuzz function has a sleep check (though it might need to account for being called to enable the sound while inst.buzzing is already set to true, if allowed), but on OnEntityWake and OnEntitySleep don't have code to handle playing or stopping the sound.

All in all, the file might need to be revised a bunch to address the issue and make sure the sound plays or not when intended. Keep inst.buzzing behavior as usual, check for this flag in relevant cases, but always check with SoundEmitter:PlayingSound to see if the sound needs to be played or stopped.

In batcave.lua:

local function onaddchild( inst, count )
    if inst.components.childspawner.childreninside == inst.components.childspawner.maxchildren then
        inst.AnimState:PlayAnimation("eyes",true)
        inst.SoundEmitter:PlaySound("dontstarve/cave/bat_cave_warning", "full")
    end
end

A not asleep check needs to be added to it, to prevent both the animation and sound from playing.

Since OnEntityWake will do it automatically, as shown below:

local function OnEntityWake(inst)
    if inst.components.childspawner.childreninside == inst.components.childspawner.maxchildren then
        inst.AnimState:PlayAnimation("eyes",true)
        inst.SoundEmitter:PlaySound("dontstarve/cave/bat_cave_warning", "full")
    end
end