ms_setmoonphase event incorrectly sets waning moon phases as waxing

Hello, I've found a bug in components/clock.lua related to how moon phases are set via the ms_setmoonphase event.
When using the ms_setmoonphase event to set a specific waning moon phase (e.g., a waning three-quarter moon), the game incorrectly sets it to the corresponding waxing phase instead. The iswaxing = false parameter is effectively ignored for certain phases.

To my mind, the root cause is in the OnSetMoonPhase function in components/clock.lua. The for loop that searches for the correct index in the MOON_PHASE_CYCLES array starts its search at the wrong position for waning phases.

The line in question is:

Quote

for i = (data.iswaxing and 1 or #MOON_PHASE_CYCLES/2), #MOON_PHASE_CYCLES do

The MOON_PHASE_CYCLES array has 20 elements. The waxing period is defined by indices 1 through 10. When data.iswaxing is false, the loop starts at index 10 (#MOON_PHASE_CYCLES/2).

The value at MOON_PHASE_CYCLES[10] corresponds to the "threequarter" phase, but it is the last day of the waxing three-quarter moon. The loop finds this match immediately, sets the internal cycle day to 10, and GetMoonPhase() subsequently (and correctly, given the index) determines the phase is waxing because 10 <= 10.

That’s how I understand it – hope I didn’t mess up and made myself clear!