Marotter food logic issues

You already pointed out the issue with not eating food from the den. But regarding the bit about not eating horrible food, this seems to be the cause:

local function FindGroundFoodToEatAction(inst)
    if inst.sg:HasStateTag("busy") or inst.components.timer:TimerExists(INTERACT_COOLDOWN_NAME) then
        return nil
    end

    -- Try to avoid picking up things that are on our home boat,
    -- because they'll get dropped there when our den is full.
    local home_position = GetHomeLocation(inst)
    local test_ground_item_for_food = function(item)
        return item:GetTimeAlive() >= 1
            and item.prefab ~= "mandrake"
            and item.components.edible ~= nil
            and item.components.edible.foodtype == FOODTYPE.MEAT -- HERE
            and inst.components.eater:CanEat(item)
            and item.components.inventoryitem ~= nil
            and (not home_position or item:GetDistanceSqToPoint(home_position) > BOAT_SIZE_SQ)
    end

There's a hardcoded check specifically for eating, the food type has to be meat. Given that they normally only eat meat otherwise, they might've forgotten to account for it here. CanEat already covers meat + horrible, so they could just get rid of it, or remove the horrible eater property from them instead.

 

Also, something else I noticed is that they don't always make use of inst.components.eater:GetEdibleTags() to send as "one of" tags for these searches? Not just for Marotters, but for many other similar cases of searching for food entities.

Using it could lighten the searches quite a bit and it'd be consistent with whatever the eater component of the entity has set at the time. Well, they'd need to set the cache to nil on adding or removing eater tags, to support changing the tags at any point and ensure this will still work properly, as it won't update otherwise, or simply set the cache variable to false so it doesn't cache at all, if memory usage is a concern.