Gestalt Abigail Fails to Revert to AoE Form in Caves

Yeah, this happens because caves have separate variables to keep track of the moon phase (the forest also has these variables and keeps track of them, there's a good reason for this, because if something can exist both in the caves and forest, making it check for a cave world state variable means it'll work consistently in both shards, not just the caves):

-- forest and caves
local function OnCaveMoonPhaseChanged2(src, data)
    SetVariable("iscavewaxingmoon", data.waxing)
    SetVariable("cavemoonphase", data.moonphase)
    SetVariable("iscavefullmoon", self.data.iscavenight and data.moonphase == "full", "fullmoon")
    SetVariable("iscavenewmoon", self.data.iscavenight and data.moonphase == "new", "newmoon")
end

-- forest
local function OnMoonPhaseChanged2(src, data)
    SetVariable("iswaxingmoon", data.waxing)
    SetVariable("moonphase", data.moonphase)
    SetVariable("isfullmoon", self.data.isnight and data.moonphase == "full", "fullmoon")
    SetVariable("isnewmoon", self.data.isnight and data.moonphase == "new", "newmoon")
    OnCaveMoonPhaseChanged2(src, data)
end

-- default variables
self.data.moonphase = "new"
self.data.iswaxingmoon = true
self.data.isfullmoon = false
self.data.isnewmoon = false

And as you can see here:

local function domutatefn(inst,doer)
    if not TheWorld.state.isnight then
        return false, "NOTNIGHT"
    elseif not doer.components.ghostlybond or not doer.components.ghostlybond.ghost then
        return false, "NOGHOST"
    elseif doer.components.ghostlybond.ghost:HasTag("gestalt") then
        if  TheWorld.state.isnewmoon or (not TheWorld.state.isfullmoon and not TheWorld.state.iswaxingmoon) then
            doer.components.ghostlybond.ghost:ChangeToGestalt(false)
        else
           return false, "NONEWMOON"
        end
    else    
        if TheWorld.state.isfullmoon or (not TheWorld.state.isnewmoon and TheWorld.state.iswaxingmoon) then
            doer.components.ghostlybond.ghost:ChangeToGestalt(true)            
        else
            return false, "NOFULLMOON"
        end        
    end

    return true
end

This is checking for the forest variables, leading it to think it's always a waxing moon.

 

I feel like either the mutation function of the Moondial shouldn't work at all given that it's basically impossible for it to track the moon phase from the caves, always been this way.

CAVE = "There's no moon down here to measure.",

Or.. it could instead always work as if there's a new moon and allow to revert from gestalt Abigail at any point. Which would help with something I've seen mentioned around regarding the Moonstorms, where you're just not able to revert her outside of character swapping.

Edited March 6, 2025 by hoxi
Typo

Changed Status to Fixed