Jump to content

Some missing prefab dependencies related to items tweaked in the update (and a bunch)


hoxi
  • Pending

I know this is very small but I couldn't help but notice, and then I might've become fixated on this and went over every case of perishable.onperishreplacement and dryable:SetProduct.

 

The following are missing spoiled_food:

  • firenettles
  • foliage
  • moon_tree_blossom (in moontree_blossom.lua)
  • petals
  • froglegs
  • ancientfruit_nightvision (also, ancientfruit_nightvision_cooked includes itself in its dependencies)
  • boatpatch_kelp
  • bullkelp_root
  • cactus_flower
  • perishable carnival foods in carnival_food.lua
  • cutlichen
  • froglegs (it's also missing "smallmeat_dried")
  • hambat
  • hareball
  • lightbulb
  • milkywhites
  • moon_cap (and moon_cap_cooked?)
  • mosquitomusk
  • red, green and blue mushroom caps (and their cooked versions?)
  • preparedfood.lua has the opposite issue for one prefab: jellybean (it can't spoil into spoiled_food)
  • rock_avocado_fruit_ripe (and rock_avocado_fruit_ripe_cooked?)
  • tillweedsalve
  • wormlight and wormlight_lesser
  • yotp_food1 and yotp_food3 (yotp_food2 doesn't spoil)
  • yotr_food1, yotr_food2, yotr_food3 and yotr_food4

 

 

In meats.lua:

  • drumstick is missing smallmeat_dried
  • batwing incorrectly has meat_dried instead of smallmeat_dried

 

Other more unique cases:

  • eel is missing fishmeat_small_dried
  • fish is missing fishmeat_small_dried
  • froglegs is missing smallmeat_dried
  • moonglass_charged is missing moonglass? Unsure if needed since it's in the same file (also prefabs in there is a undefined variable)

 

In oceanfish.lua:

	local prefabs = {
		data.prefab.."_inv",
		"schoolherd_"..data.prefab,
		"spoiled_fish",
		data.cooking_product,
	}

"spoiled_fish" here should be data.perish_product (or at least it should be added there, but I don't think "spoiled_fish" needs to be kept there?).

 

In pondfish.lua:

local pondfish_prefabs =
{
	"fishmeat_small",
    "fishmeat_small_cooked",
    "spoiled_fish",
}

local pondeel_prefabs =
{
	"fishmeat_small",
    "fishmeat_small_cooked",
	"eel",
}

return Prefab("pondfish", pondfishfn, assets, pondeel_prefabs),
	Prefab("pondeel", pondeelfn, assets, pondeel_prefabs)

Should look like:

local pondfish_prefabs =
{
	"fishmeat_small",
    "fishmeat_small_cooked",
}

local pondeel_prefabs =
{
	"eel",
    "eel_cooked",
}

return Prefab("pondfish", pondfishfn, assets, pondfish_prefabs),
	Prefab("pondeel", pondeelfn, assets, pondeel_prefabs)

 

 

In meatrack2.lua:

local prefabs =
{
	"collapse_small",

	-- everything it can "produce" and might need symbol swaps from
	"smallmeat",
	"smallmeat_dried",
	"monstermeat",
	"monstermeat_dried",
	"humanmeat",
	"humanmeat_dried",
	"meat",
	"meat_dried",
	"drumstick", -- uses smallmeat_dried
	"batwing", --uses smallmeat_dried
	"fish", -- uses smallmeat_dried
	"froglegs", -- uses smallmeat_dried
    "fishmeat",
    "fishmeat_dried",
    "fishmeat_small",
    "fishmeat_small_dried",
	"eel",
	"kelp",
	"kelp_dried",
}

I'm not sure if it's intentional but, shouldn't this also include:

  • spoiled_food
  • spoiled_fish
  • spoiled_fish_small

Plus all the new dried leaves, plants and petals that this beta introduced?

 

 

EDIT: found this one as well.

function SimulateKoalefantDrops(inst) -- Intentionally global.
    -- NOTES(JBK): This simulates a koalefant being spawned and slain followed up with meats eaten at random.
    -- 'inst' must have lootdropper already.
    -- Dependencies of "meat", "trunk_winter", "trunk_summer" are expected in the prefabs table for any prefab using this.
    for i = 1, 2 do
        local loot = SpawnPrefab("meat")
        inst.components.lootdropper:FlingItem(loot)
    end
    if math.random() < 0.5 then
        local loot = SpawnPrefab(TheWorld.state.iswinter and "trunk_winter" or "trunk_summer")
        inst.components.lootdropper:FlingItem(loot)
    end
end

Regarding those notes? The spat dependencies (in spat.lua) is actually lacking the trunk prefabs:

local prefabs =
{
    "meat",
    "poop",
    "steelwool",
    "phlegm",
    "spat_bomb",
}

Just don't forget to add this to spat as well:

local scrapbook_removedeps_basic =
{
    "trunk_summer",
    "trunk_winter",
}

 

Also.. a bit unrelated but I couldn't help but be reminded of how weird it is that, despite the Ewecus only eating vegetables, why does the simulated killed Koalefant only drop 2 meat and the trunk is subjected to a 50% roll..? Where does the meat go if the Ewecus doesn't eat meat..? (not to mention that the Ewecus doesn't really scale at all with how fast the hunt was completed, only if the player takes too long to get ambushed)


Steps to Reproduce

Nothing to reproduce.

  • Like 2



User Feedback


There are no comments to display.



Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

×
  • Create New...