Jump to content

Pirate monkey stashes don't attempt to stack items, causing them to fill up quickly and delete items

hoxi

By hoxi

    • Fixed

Self-explanatory.

The main source of this issue is that powder monkeys from the Moon Quay island will store things from their inventories in the stash when entering their homes. They can grab a few different items from the portal, go home, store the items, and because the same items they (or other monkeys) grabbed previously won't stack, the stash gets full quickly and things start getting deleted when it cycles back to slot 1.

 

Also please consider allowing more than one stash in the world when one becomes full, to further alleviate issues of items getting deleted (even 2 at a time, especially if items not stacking is fixed, would be huge). Or at the very least regardless of what's done, prioritize deleting items spawned by the portal instead.

Steps to Reproduce
  1. Keep track of what's inside the pirate stash using debug tools.
  2. Go to the Moon Quay island and wait around while monkeys grab things and go back to their huts.
  3. Notice how stackable items aren't stacked, and the stash can fill up rather quickly, cycle back in slots, and eventually start deleting items.
Go to bugs

User Feedback


A developer has marked this issue as fixed. This means that the issue has been addressed in the current development build and will likely be in the next update.
hoxi

This was addressed in the last update!

However there's one issue that carried over: 

    -- No open slot.
    if not leftovers:HasTag("irreplaceable") then
        leftovers:Remove()

    elseif leftovers.components.inventoryitem ~= nil then
        leftovers.components.inventoryitem:DoDropPhysics(x, 0, z, true) --here

    elseif leftovers.Physics ~= nil then
        Launch(item, item, 1)

    else
        leftovers.Transform:SetPosition(inst.Transform:GetWorldPosition())
    end

x and z aren't defined for the DoDropPhysics call, which would cause a crash.

  • Like 1

Share this comment

Link to comment
Share on other sites


Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

×
×
  • Create New...