This happens because when checking for container.isexposed, there's no check for the owner or grandowner of an item having rain immunity, but will also happen when mounting Woby even if this is fixed, more on this below.
What'd be expected is that if the grandowner (regardless of being a container or not) has rain immunity, items inside an exposed container (or multiple) shouldn't count as exposed.
While things work fine for the Woby drying rack because they're manually handled there, the actual items will get wet even if inside an Umbralla dome, because that specifically isn't accounted for. This actually does have an effect on things because despite items being preserved when drying, dried items aren't.
Keep in mind, due to the nature of Woby (and Beefalos) getting limbo'd when mounted, she will never be able to be rain immune when mounted, but the player will, so something like that has to be checked for too. More on a solution for that below.
Other similar things I can think of that should make use of a system like this (and this system should be expanded a bit more) are:
- Fishing Rod: uses a container for two item slots, but it should be an exposed container.
- Tin Fishin' Bin: not a matter of being exposed or not, but fish in it should stay at 100 wetness, as they're under the boat (they should also instantly gain max wetness on being put in one).
- Ocean Trawler: same as the above, but only when submerged (although it should be an exposed container otherwise).
These things and the specifics of Woby's drying rack, makes me think that the GetTargetMoisture function should check for a custom function and return what the function returns, if such a function is defined, to allow proper specific cases to work as expected.
Maybe containers and inventories should get their own GetTargetMoisture functions too (like for the Tin Fishin' Bin and Ocean Trawler, to either return 100, or 0 in the case of a raised trawler), and let those handle things through them too.
This would not only expand modding capabilities quite a bit, but also potentially prevent cases like these in the future, without having to always update inventoryitemmoisture for specific bits (though I do think that at the very least, it does need to account for some common stuff like the grandowner bit mentioned at the start).
- Feed Woby until she turns into big Woby.
- Place meat or kelp on Woby's drying rack.
- Place and activate an Umbralla and keep Woby within the dome.
- Notice that during rain, the items that are drying there will still gain wetness (but will properly "dry" into a dried food item).
A developer has marked this issue as fixed. This means that the issue has been addressed in the current development build and will likely be in the next update.
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now