Dropping it on the ground enables its light. Picking it up disables its light. Putting a spore inside enables its light. Removing a spore from it disables the light. Thus:
- Open it on the ground and remove a spore → disabled on the ground
- Hold it and put in a spore directly (‘Store’ action) → enabled while held
- Drop an empty shard → enabled while empty
- Pick up a spore-laden shard from the ground → disabled while full
Surely at least some part of the behaviour here is unintended?
Maybe the light’s state could depend only on whether or not it’s held? Maybe UpdateLightState should only change the colour, without calling Light:Enable?
Or maybe the light should be a function of whether or not it contains a spore? Then OnPickup and OnDropped would be unnecessary—though it’d be marginally more complex if you want to avoid the following.
Steps to Reproduce
- c_give("alterguardianhatshard")
- c_give("spore_medium")
-
Put spore into crown shard without removing from inventory
- Observe glow in inventory
-
Open the shard, remove spore
- Observe darkness on the ground
-
Pick it up, open it again (which drops it)
- Observe glow while empty
-
Put a spore inside, pick it up
- Observe darkness while full
A developer has marked this issue as fixed. This means that the issue has been addressed in the current development build and will likely be in the next update.
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now