together [help] screecher camera

[Jan_Gardy]

Hello I'm making a mod for the camera from the Screecher mod, but there are bugs, I'm a newbie who doesn't know much about the code, I need help.

if anyone knows what's causing the problems, can you examine the code?

if you want to help me in mod development, here is my steam profile: https://steamcommunity.com/profiles/76561199314379206/

modinfo.lua^

Spoiler

--The name of the mod displayed in the 'mods' screen.
name = "Screecher Camera"

--A description of the mod.
description = "Screecher Camera"

--Who wrote this awesome mod?
author = "jan and Klei"

--A version number so you can ask people if they are running an old version of your mod.
version = "1.5"

--This lets other players know if your mod is out of date.  This typically needs to be updated every time there's a new game update.
api_version = 10

-- Compatible with both the base game and reign of giants
dst_compatible = true
dont_starve_compatible = true
reign_of_giants_compatible = true
client_only_mod = true

--Some mods may crash or not work correctly until the game is restarted after the mod is enabled/disabled
restart_required = false

-- Set this to true to prevent _ANY_ other mods from loading while this mod is enabled.
standalone = false

icon_atlas = "screechericon.xml"
icon = "screechericon.tex"

forumthread = ""

modmain.lua:

Spoiler

-- CAMERA values
GLOBAL.TUNING.MOUSE_SENSITIVITY = 0.15 -- Was originally 1.5
GLOBAL.TUNING.PITCH_ADJUSTMENT_MULTIPLIER = 5
GLOBAL.TUNING.DEFAULT_CAM_DISTANCE = 13
GLOBAL.TUNING.ZOOMED_CAM_DISTANCE = 10
GLOBAL.TUNING.PITCH_ADDITIONAL_OFFSET = 0.2
GLOBAL.TUNING.CAMERAY_OFFSET = 2

GLOBAL.TUNING.IS_FPS = false
if GLOBAL.TUNING.IS_FPS then
    GLOBAL.TUNING.DEFAULT_CAM_DISTANCE = 8
    GLOBAL.TUNING.ZOOMED_CAM_DISTANCE = 8
    GLOBAL.TUNING.CAMERAY_OFFSET = 4.5
end

-- DoPeriodicTask needs to be executed in the ModWorldInit function
AddSimPostInit(function()
    local player = ThePlayer 
    if player then
        player:DoPeriodicTask(0, function()
            local playerfacing = player.Transform:GetRotation()
            TheCamera:SetHeadingTarget(-playerfacing + 180) 
        end)
    end
end)

followcamera.lua:

Spoiler

FollowCamera = Class(function(self, inst)
    self.inst = inst
    self.target = nil
    self:SetDefault()
    self:Snap()
    
    self.time_since_zoom = nil

    self.currentpos = Vector3(0, 0, 0)

    self.onUpdateFn = nil
end)

DEFAULT_MIN_PITCH = 14
DEFAULT_MAX_PITCH = 40
loweroffset = TUNING.CAMERAY_OFFSET

function FollowCamera:SetDefault()
    self.targetpos = Vector3(0,0,0)
    self.targetoffset = Vector3(0,6.5-loweroffset,0)

    self.distancetarget = TUNING.DEFAULT_CAM_DISTANCE
    self.mindist = 14
    self.maxdist = 25

    self.pitchpercent = 0.5
    
    self.mindistpitch = DEFAULT_MIN_PITCH
    self.maxdistpitch = DEFAULT_MAX_PITCH

    if self.headingtarget == nil then
        self.headingtarget = 45
    end

    self.fov = 35
    self.pangain = 4
    self.headinggain = 20
    self.distancegain = 1

    self.zoomstep = 4

    self.paused = false
    self.shake = nil
    self.controllable = false
    self.cutscene = false
end

function FollowCamera:SetPitchOffset(pitchoffset)
    self.mindistpitch = DEFAULT_MIN_PITCH-pitchoffset
    self.maxdistpitch = DEFAULT_MAX_PITCH-pitchoffset
end

function FollowCamera:SetOnUpdateFn(updateFn)
    self.onUpdateFn = updateFn
end

function FollowCamera:SetPitchPercent(pct)

--jcheng: this is so the light map doesn't flicker. It's a magic number that 0.75 is BAD, given the current MAX / MIN pitch
    local eqepsilon = function(val1, val2)
        return math.abs(val1 - val2) < 0.015--0.005 
    end
    if eqepsilon( pct, 0.865 ) then
        if pct < 0.865 then
            pct = 0.849
        else
            pct = 0.881
        end
    end

    self.pitchpercent = 1-pct
    --print("pitchpct: "..tostring(pct))
end

function FollowCamera:GetRightVec()
    return Vector3(math.cos((self.headingtarget + 90)*DEGREES), 0, math.sin((self.headingtarget+ 90)*DEGREES))
end

function FollowCamera:GetDownVec()
    return Vector3(math.cos((self.headingtarget)*DEGREES), 0, math.sin((self.headingtarget)*DEGREES))
end

function FollowCamera:SetPaused(val)
    self.paused = val
end

function FollowCamera:SetMinDistance(distance)
    self.mindist = distance
end

function FollowCamera:SetGains(pan, heading, distance)
    self.distancegain = distance
    self.pangain = pan
    self.headinggain = heading
end

function FollowCamera:IsControllable()
    return self.controllable
end

function FollowCamera:SetControllable(val)
    self.controllable = val
end

function FollowCamera:CanControl()
    return self.controllable
end

function FollowCamera:SetOffset(offset)
    self.targetoffset = offset
end

function FollowCamera:GetDistance()
    return self.distancetarget
end

function FollowCamera:SetDistance(dist)
    self.distancetarget = dist
end

function FollowCamera:Shake(type, duration, speed, scale)
    self.shake = CameraShake(type, duration, speed, scale)
end

function FollowCamera:SetTarget(inst)
    self.target = inst
    self.targetpos.x, self.targetpos.y, self.targetpos.z = self.target.Transform:GetWorldPosition()
    self.currentpos.x, self.currentpos.y, self.currentpos.z = self.target.Transform:GetWorldPosition()
end

function FollowCamera:Apply()  
        local dir = Vector3(0,0,0)
        dir.x = -math.cos(self.pitch*DEGREES)*math.cos(self.heading*DEGREES)
        dir.y = -math.sin(self.pitch*DEGREES)
        dir.z = -math.cos(self.pitch*DEGREES)*math.sin(self.heading*DEGREES)

        local pos = dir*(-self.distance) + self.currentpos 
        local right = Vector3(math.cos((self.heading+90)*DEGREES), 0, math.sin((self.heading+90)*DEGREES))
        local up = dir:Cross(right)

        TheSim:SetCameraDir(dir.x,dir.y,dir.z)
        TheSim:SetCameraPos(pos.x,pos.y,pos.z)
        TheSim:SetCameraUp(up.x, up.y, up.z)
        TheSim:SetCameraFOV(self.fov)
        
        local listenpos = dir*(-self.distance*.1) + self.currentpos
        TheSim:SetListener(listenpos.x, listenpos.y, listenpos.z, dir.x, dir.y, dir.z, up.x, up.y, up.z)
end

local lerp = function(lower, upper, t)
   if t > 1 then t = 1 elseif t < 0 then t = 0 end
   return lower*(1-t)+upper*t 
end

function FollowCamera:GetHeading()
    return self.heading
end
function FollowCamera:GetHeadingTarget()
    return self.headingtarget
end

function FollowCamera:SetHeadingTarget(r)
    self.headingtarget = r
end

function FollowCamera:Snap()
    if self.target then
        self.targetpos = Vector3(self.target.Transform:GetWorldPosition()) + self.targetoffset
    else
        self.targetpos = self.targetoffset
    end

    self.currentpos = self.targetpos
    self.heading = self.headingtarget
    self.distance = self.distancetarget
    --self.pitchpercent

    self.pitch = lerp(self.mindistpitch, self.maxdistpitch, self.pitchpercent)
    
    self:Apply()
end

function FollowCamera:CutsceneMode(b)
    self.cutscene = b
end

function FollowCamera:SetCustomLocation(loc)
    self.targetpos = loc
end

function FollowCamera:Update(dt)

    if self.paused then
        return
    end

    if self.onUpdateFn then
        self.onUpdateFn(dt)
    end

    if self.cutscene then

        self.currentpos = lerp(self.currentpos, self.targetpos + self.targetoffset, dt*self.pangain)

        if self.shake then
            local shakeOffset = self.shake:Update(dt)
            if shakeOffset then
                local upOffset = Vector3(0, shakeOffset.y, 0)
                local rightOffset = self:GetRightVec() * shakeOffset.x
                self.currentpos = self.currentpos + upOffset + rightOffset
            else
                self.shake = nil
            end
        end

        local delta = self.heading -self.headingtarget
        while delta > 180 do delta = delta - 360 end
        while delta < -180 do delta = delta + 360 end
        if math.abs(delta) > .1 then
            self.heading = self.heading + (delta / 4)
            --self.heading = lerp(self.heading, self.headingtarget, dt*self.headinggain)    
        end

        if math.abs(self.distance - self.distancetarget) > .01 then
            self.distance = lerp(self.distance, self.distancetarget, dt*self.distancegain)    
        end

        self.pitch = lerp(self.mindistpitch, self.maxdistpitch, self.pitchpercent)

    else
        if self.time_since_zoom then
            self.time_since_zoom = self.time_since_zoom + dt
        
            if self.should_push_down and self.time_since_zoom > .25 then
                self.distancetarget = self.distance - self.zoomstep
            end
        end

        if self.target then
            self.targetpos = Vector3(self.target.Transform:GetWorldPosition()) + self.targetoffset
        else
            self.targetpos = self.targetoffset
        end

        self.currentpos = lerp(self.currentpos, self.targetpos, dt*self.pangain)
        
        if self.shake then
            local shakeOffset = self.shake:Update(dt)
            if shakeOffset then
                local upOffset = Vector3(0, shakeOffset.y, 0)
                local rightOffset = self:GetRightVec() * shakeOffset.x
                self.currentpos = self.currentpos + upOffset + rightOffset
            else
                self.shake = nil
            end
        end
        
        local delta = self.headingtarget - self.heading
        while delta > 180 do delta = delta - 360 end
        while delta < -180 do delta = delta + 360 end
        if math.abs(delta) > .1 then
            self.heading = self.heading + (delta / 4)
        end
        -- if math.abs(self.heading - self.headingtarget) > .01 then
        --     self.heading = lerp(self.heading, self.headingtarget, dt*self.headinggain)    
        -- else
        --     self.heading = self.headingtarget
        -- end

        if math.abs(self.distance - self.distancetarget) > .01 then
            self.distance = lerp(self.distance, self.distancetarget, dt*self.distancegain)    
        else
            self.distance = self.distancetarget
        end
        
        self.pitch = lerp(self.mindistpitch, self.maxdistpitch, self.pitchpercent)
    end
    self:Apply()

    
end

return FollowCamera
 

modinfo.lua modmain.lua followcamera.lua