Hrafnar

I think I found two typos in unused code: scenarios/eyebone_ghost.lua: OnDestory instead of OnDestroy 39:local function OnDestory(inst) 50: OnDestory = OnDestory components/playermetrics.lua: prorotyped instead of prototyped 9: PushEvent("character.prorotyped", inst, { prefab = data.recipe })

I think I found some places where inst.components.inventoryitem:GetGrandOwner() should be used: scenarios/staff_hounds.lua, line 30: inst.scene_putininventoryfn should use inst.components.inventoryitem:GetGrandOwner() instead of the event's owner parameter, which might be an overflow container. Otherwise the player won't lose sanity when the staff lands in an equipped backpack. components/follower.lua, lines 122-123, 199-200: components.inventoryitem:GetGrandOwner() should be used instead of components.inventoryitem.owner, which might be an overflow container. (Line numbers are those from the current A New Reign Beta release)

Not a bug in DST itself, but a bug in the ModUploader (there's no appropriate bug tracker here): Nearly every attempt to update an existing DST mod on Linux (Debian stretch/sid) fails, while the first-time uploads all succeeded so far. Running the Windows version through Wine succeeds. The error from ~/.local/share/DontStarveModUploader/ModUploader.log: [...] 18:08:11: zipOpenNewFileInZip(scripts/prefabs/reincarnationshot.lua) ok 18:08:11: fopen(/home/USER/.steam/steam/steamapps/common/Don't Starve Together/mods/dst_mod_reincarnation/build/scripts/prefabs/reincarnationshot.lua) ok: 0 18:08:11: zipWriteInFileInZip ok 18:08:11: Progress: Writing mod data file... 18:08:11: WriteFileToCloud() Writing [/tmp/modCV9xio] to [mod_publish_data_file.zip] 18:08:11: Steam file exists. 18:08:11: Read file failed! 18:08:11: EndProgress FAILED: Failed to write mod data file! 18:08:11: MainFrame::OnUpdateComplete FAILED: Failed to write mod data file! 18:08:18: RefreshPublishedModInfo [...]

On line 59/61 in scripts/prefabs/whip.lua, the else/end statements are switched: if math.random() < chance then snap.Transform:SetScale(3, 3, 3) snap.SoundEmitter:PlaySound("dontstarve/common/whip_large") inst:DoTaskInTime(0, supercrack) end snap.SoundEmitter:PlaySound("dontstarve/common/whip_small") else This should most likely read: if math.random() < chance then snap.Transform:SetScale(3, 3, 3) snap.SoundEmitter:PlaySound("dontstarve/common/whip_large") inst:DoTaskInTime(0, supercrack) else snap.SoundEmitter:PlaySound("dontstarve/common/whip_small") end Diff: --- a/scripts/prefabs/whip.lua +++ b/scripts/prefabs/whip.lua @@ -56,9 +56,9 @@ local function onattack(inst, attacker, target) snap.Transform:SetScale(3, 3, 3) snap.SoundEmitter:PlaySound("dontstarve/common/whip_large") inst:DoTaskInTime(0, supercrack) - end - snap.SoundEmitter:PlaySound("dontstarve/common/whip_small") else + snap.SoundEmitter:PlaySound("dontstarve/common/whip_small") + end end end