Jump to content
Rotwood Coming to Steam Early Access April 24

Player_common crashing from a custom resurrection source

FelixTheJudge

By FelixTheJudge

    • Fixed

Line 971 is       
  

  (data.user ~= nil and data.user:GetDisplayName()) or



when it needs to be
  

        (data ~= nil and data.user ~= nil and data.user:GetDisplayName()) or



Tested it myself.
Works fine.

Without this, any mod that uses a custom resurrection function via custom action or an Area of Effect resurrection function will crash.
This didn't crash before, a recent update seems to have caused this.

Steps to Reproduce
use any custom resurrection function via PushEvent("respawnfromghost") thats not one of the specified prefabs in player_common. Causes a crash.
Go to bugs

User Feedback


A developer has marked this issue as fixed. This means that the issue has been addressed in the current development build and will likely be in the next update.
rezecib

I don't think this is a bug. You should be passing data along with the event, like so: 

player:PushEvent("respawnfromghost", {})

You may need more entries in that table, but the line you cited is catching one of them at least.

Share this comment

Link to comment
Share on other sites
FelixTheJudge

so what do I put inside { }?

btw, my script is currently using v:PushEvent("respawnfromghost") as its an aoe revival effect.

This also didn't crash until a recent update.

However, your fix does help. Thank you rezecib. I didn't know exactly how to pass data with the pushevent.

Edited by FelixTheJudge

Share this comment

Link to comment
Share on other sites
V2C

Sorry about that, it did use to support nil data.  We'll have that fixed in our next updates.

Share this comment

Link to comment
Share on other sites


Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

×
×
  • Create New...